Skip to content

[WIP] API simplification#16

Draft
Copilot wants to merge 2 commits intodevelopfrom
copilot/fix-15
Draft

[WIP] API simplification#16
Copilot wants to merge 2 commits intodevelopfrom
copilot/fix-15

Conversation

Copy link
Contributor

Copilot AI commented May 22, 2025

  • Modify Coordinate structure in SpatialLite.Core.API
    • Remove Z and M properties
    • Remove related constructors for Z and M
    • Remove Is3D and IsMeasured methods
    • Update equality methods and GetHashCode
    • Update ToString() method
    • Update the Empty constant
  • Update related code in SpatialLite.Core
    • Update code that creates Coordinates with Z and M values
    • Update code that accesses Z and M properties
    • Update code that calls Is3D and IsMeasured methods
  • Update tests to reflect API changes
    • Remove tests specific to Z and M
    • Update tests that use Z and M values
  • Verify all tests pass after modifications

Fixes #15.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@lukaskabrt
Copy link
Owner

  • Modify Coordinate structure in SpatialLite.Core.API

    • Remove Z and M properties
    • Remove related constructors for Z and M
    • Remove Is3D and IsMeasured methods
    • Update equality methods and GetHashCode
    • Update ToString() method
    • Update the Empty constant
  • Update related code in SpatialLite.Core

    • Update code that creates Coordinates with Z and M values
    • Update code that accesses Z and M properties
    • Update code that calls Is3D and IsMeasured methods
  • Update tests to reflect API changes

    • Remove tests specific to Z and M
    • Update tests that use Z and M values
  • Verify all tests pass after modifications

Fixes #15.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@copilot continue please

@lukaskabrt
Copy link
Owner

@copilot continue please.

@lukaskabrt
Copy link
Owner

@copilot please continue.

…unctionality

Co-authored-by: lukaskabrt <2894161+lukaskabrt@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented May 23, 2025

@copilot please continue.

I've made significant progress on the API simplification. The core Coordinate structure has been updated to remove Z and M properties, related constructors, and methods. All core SpatialLite functionality has been updated including geometries, IO classes, and interfaces. The project builds successfully.

Next step is to fix the remaining test files that still reference the old API. Progress will continue systematically. Commit: 3eaf1b1

@lukaskabrt
Copy link
Owner

@copilot please continue

Copy link
Contributor Author

Copilot AI commented May 25, 2025

@copilot please continue

I'm continuing with the API simplification. I've made significant progress updating SpatialLite.Gps components and related tests to work with the new Coordinate API. Changes include:

  1. Removed Is3D and IsMeasured methods from RelationMember class
  2. Updated GpsPoint and GpxPoint constructors to remove Z parameter
  3. Modified GpxWriter to handle the lack of Z coordinate
  4. Updated test cases across the codebase to work with 2D coordinates

Still working on fixing the remaining test files, particularly in the GPS module and WKT readers/writers. Latest commit: 7f31fd3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API simplification

2 participants